Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PHP 8.3 support to PHP-Parser 4.x #935

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

ondrejmirtes
Copy link
Contributor

Hello,
PHPStan is a bit between a rock and a hard place regarding PHP 8.3 support. I understand you want to support PHP 8.3 features only with PHP-Parser 5.

But I can upgrade to PHP-Parser 5 only in PHPStan 2.0. Additionally, PHPStan depends on BetterReflection which also needs to release a new version that works with PHP-Parser 5 before I can use it in PHPStan. And also Rector depends on PHPStan which means that Rector can support PHP 8.3 only once PHPStan does.

But I want to support PHP 8.3 as soon as possible with PHPStan and I don't want to be forced to release PHPStan 2.0 sooner than I'd want because of that. I'd like to have PHP 8.3 support and 2.0 release as separate milestones.

So I'd like to decouple and deconstruct this situation to remove a bottleneck and to make this easier between PHPStan <-> BetterReflection <-> Rector. Support for PHP 8.3 in 4.x would really help me with that.

I prepared a branch where I cherry-picked the commits. I'd understand if you don't want to merge this. In that case I'll use a temporary PHP-Parser fork in PHPStan 1.x with these commits. (Rector will also likely need to use the same fork.)

Thanks for understanding.

/cc @TomasVotruba

@nikic nikic merged commit cfc54e3 into nikic:4.x Jul 30, 2023
10 checks passed
@ondrejmirtes
Copy link
Contributor Author

Thank you, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants