Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EncapsedStringPart] Add rawValue attribute #837

Closed
wants to merge 2 commits into from
Closed

[EncapsedStringPart] Add rawValue attribute #837

wants to merge 2 commits into from

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented May 16, 2022 •
edited

  • add fromStringParsed() and fromString() methods to EncapsedStringPart to keep raw value
  • add EncapsedStringPartTest

Follow up to:

@TomasVotruba TomasVotruba changed the title tv raw value encapsed [EncapsedStringPart] Add rawValue attribute May 16, 2022
@TomasVotruba
Copy link
Contributor Author

Ready for review ✔️

@TomasVotruba TomasVotruba mentioned this pull request May 16, 2022
Merged
@TomasVotruba
Copy link
Contributor Author

What needs to be done here?

@pmjones pmjones mentioned this pull request Sep 22, 2023
Closed
@nikic
Copy link
Owner

nikic commented Sep 24, 2023

I've implemented a variation on this (with some additional handling for doc strings) in f5adbb5.

@nikic nikic closed this Sep 24, 2023
@TomasVotruba
Copy link
Contributor Author

Thanks 👏

@TomasVotruba TomasVotruba deleted the tv-raw-value-encapsed branch September 24, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomasVotruba @nikic