Add attribute of raw string to Scalar String_ #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
reviewed
Jun 23, 2019
|
Thanks for the reviews, I've updated my code accordingly and squashed them to one commit ☀️ |
|
@nikic Is this something you plan to approve? |
|
Similar node would be useful for |
|
@nikic If you plan to accept this, I can submit PR with rebasd and correct implementation in grammer recipe. |
|
@TomasVotruba Might be better to just create a new PR. He doesn't seem to respond to some PRs. |
|
Let's finish this in #831 |
|
Closing in favor of #831, which implements this as an attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576