Early return false after VariadicPlaceholder check on CallLike::isFir…

…stClassCallable() (#924) VariadicPlaceholder can only occur as the first (and only) argument, so avoid a loop to check for it.
nikic · Jun 25, 2023 · eaa1d91 · eaa1d91
1 parent 3fb4b92
commit eaa1d91
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/PhpParser/Node/Expr/CallLike.php b/lib/PhpParser/Node/Expr/CallLike.php
@@ -19,12 +19,8 @@ abstract public function getRawArgs(): array;
      * Returns whether this call expression is actually a first class callable.
      */
     public function isFirstClassCallable(): bool {
-        foreach ($this->getRawArgs() as $arg) {
-            if ($arg instanceof VariadicPlaceholder) {
-                return true;
-            }
-        }
-        return false;
+        $rawArgs = $this->getRawArgs();
+        return count($rawArgs) === 1 && current($rawArgs) instanceof VariadicPlaceholder;
     }
 
     /**