Avoid by-reference iteration in NodeTraverser

No need to create reference wrappers around every element in the array.
nikic · Sep 26, 2023 · de84f76 · de84f76
1 parent b4183c2
commit de84f76
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/PhpParser/NodeTraverser.php b/lib/PhpParser/NodeTraverser.php
@@ -175,7 +175,7 @@ protected function traverseNode(Node $node): void {
     protected function traverseArray(array $nodes): array {
         $doNodes = [];
 
-        foreach ($nodes as $i => &$node) {
+        foreach ($nodes as $i => $node) {
             if ($node instanceof Node) {
                 $traverseChildren = true;
                 $visitorIndex = -1;
@@ -185,7 +185,7 @@ protected function traverseArray(array $nodes): array {
                     if (null !== $return) {
                         if ($return instanceof Node) {
                             $this->ensureReplacementReasonable($node, $return);
-                            $node = $return;
+                            $nodes[$i] = $node = $return;
                         } elseif (\is_array($return)) {
                             $doNodes[] = [$i, $return];
                             continue 2;
@@ -225,7 +225,7 @@ protected function traverseArray(array $nodes): array {
                     if (null !== $return) {
                         if ($return instanceof Node) {
                             $this->ensureReplacementReasonable($node, $return);
-                            $node = $return;
+                            $nodes[$i] = $node = $return;
                         } elseif (\is_array($return)) {
                             $doNodes[] = [$i, $return];
                             break;