Add makeReadonly() to param builder

(cherry picked from commit 11e2dcd)
nikic · May 19, 2023 · b68fb76 · b68fb76
1 parent 36a6dcd
commit b68fb76
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/lib/PhpParser/Builder/Param.php b/lib/PhpParser/Builder/Param.php
@@ -84,7 +84,7 @@ public function makeVariadic() {
     }
 
     /**
-     * Makes the parameter public.
+     * Makes the (promoted) parameter public.
      *
      * @return $this The builder instance (for fluid interface)
      */
@@ -95,7 +95,7 @@ public function makePublic() {
     }
 
     /**
-     * Makes the parameter protected.
+     * Makes the (promoted) parameter protected.
      *
      * @return $this The builder instance (for fluid interface)
      */
@@ -106,7 +106,7 @@ public function makeProtected() {
     }
 
     /**
-     * Makes the parameter private.
+     * Makes the (promoted) parameter private.
      *
      * @return $this The builder instance (for fluid interface)
      */
@@ -116,6 +116,17 @@ public function makePrivate() {
         return $this;
     }
 
+    /**
+     * Makes the (promoted) parameter readonly.
+     *
+     * @return $this The builder instance (for fluid interface)
+     */
+    public function makeReadonly() {
+        $this->flags = BuilderHelpers::addModifier($this->flags, Modifiers::READONLY);
+
+        return $this;
+    }
+
     /**
      * Adds an attribute group.
      *

diff --git a/test/PhpParser/Builder/ParamTest.php b/test/PhpParser/Builder/ParamTest.php
@@ -241,6 +241,18 @@ public function testMakePrivate() {
         );
     }
 
+    public function testMakeReadonly() {
+        $node = $this->createParamBuilder('test')
+            ->makeReadonly()
+            ->getNode()
+        ;
+
+        $this->assertEquals(
+            new Node\Param(new Expr\Variable('test'), null, null, false, false, [], Modifiers::READONLY),
+            $node
+        );
+    }
+
     public function testAddAttribute() {
         $attribute = new Attribute(
             new Name('Attr'),