Remove unnecessary Node return value from traverseNode()

The node always stays the same: We may only change subnodes.
nikic · May 28, 2023 · 53f6717 · 53f6717
1 parent 5b65f9f
commit 53f6717
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/lib/PhpParser/NodeTraverser.php b/lib/PhpParser/NodeTraverser.php
@@ -86,10 +86,8 @@ public function traverse(array $nodes): array {
      * Recursively traverse a node.
      *
      * @param Node $node Node to traverse.
-     *
-     * @return Node Result of traversal (may be original node or new one)
      */
-    protected function traverseNode(Node $node): Node {
+    protected function traverseNode(Node $node): void {
         foreach ($node->getSubNodeNames() as $name) {
             $subNode =& $node->$name;
 
@@ -128,7 +126,7 @@ protected function traverseNode(Node $node): Node {
                 }
 
                 if ($traverseChildren) {
-                    $subNode = $this->traverseNode($subNode);
+                    $this->traverseNode($subNode);
                     if ($this->stopTraversal) {
                         break;
                     }
@@ -162,8 +160,6 @@ protected function traverseNode(Node $node): Node {
                 }
             }
         }
-
-        return $node;
     }
 
     /**
@@ -213,7 +209,7 @@ protected function traverseArray(array $nodes): array {
                 }
 
                 if ($traverseChildren) {
-                    $node = $this->traverseNode($node);
+                    $this->traverseNode($node);
                     if ($this->stopTraversal) {
                         break;
                     }