Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增测试 #380

Merged
merged 5 commits into from
May 17, 2024
Merged

新增测试 #380

merged 5 commits into from
May 17, 2024

Conversation

AliceLanniste
Copy link
Contributor

image
我新增测试但是contextMenu.js文件中,出现这个错误导致测试failed。

@AliceLanniste AliceLanniste changed the title 新增测试但是window is not defined 新增测试 May 10, 2024
@AliceLanniste AliceLanniste marked this pull request as ready for review May 10, 2024 14:28
@nihaojob
Copy link
Owner

太感谢大佬了,增加了第一个单元测试,有2个小问题,可以一起讨论下哈

  1. 依赖需要安装到package/core里,未来Core的单元测试需要和项目解耦。
  2. 是否可以将单元测试的代码和vite配置放在core目录中?

@AliceLanniste
Copy link
Contributor Author

可以我改下

@Qiu-Jun
Copy link
Collaborator

Qiu-Jun commented May 17, 2024

太感谢大佬了,增加了第一个单元测试,有2个小问题,可以一起讨论下哈

  1. 依赖需要安装到package/core里,未来Core的单元测试需要和项目解耦。
  2. 是否可以将单元测试的代码和vite配置放在core目录中?

都开始搞单测了啊

@nihaojob
Copy link
Owner

太感谢大佬了,增加了第一个单元测试,有2个小问题,可以一起讨论下哈

  1. 依赖需要安装到package/core里,未来Core的单元测试需要和项目解耦。
  2. 是否可以将单元测试的代码和vite配置放在core目录中?

都开始搞单测了啊
AliceLanniste 大佬给力 ,给项目接入了 vitest

@nihaojob nihaojob merged commit 528344f into nihaojob:main May 17, 2024
1 check passed
@nihaojob
Copy link
Owner

@AliceLanniste 感谢大佬,已合并到主分支

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants