Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command args showing as '[object Object]' in reporter. #4195

Merged
merged 2 commits into from May 5, 2024
Merged

Fix command args showing as '[object Object]' in reporter. #4195

merged 2 commits into from May 5, 2024

Conversation

garg3133
Copy link
Member

Right now, if the command arg is of type object, it gets stringified as '[object Object]' in the reporter.

image

This PR fixes this by stringifying the args correctly using JSON.stringify.

@github-actions GitHub Actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@AutomatedTester
Copy link
Member

Looks like we need to update some tests

@garg3133 garg3133 merged commit bfcc09a into nightwatchjs:main May 5, 2024
17 checks passed
@garg3133 garg3133 deleted the fix-stringifyArgs branch May 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garg3133 @AutomatedTester