fix(element-finder): handle element not found errors correctly #4079

examples/wali/test.js

@@ -0,0 +1,41 @@
+describe('Element Finder', function () {
+  before(function (browser) {
+    browser.navigateTo('https://github.com/login');
+  });
+
+  it('should handle elements not found', function(browser) {
+    const result = browser
+      .waitForElementVisible('body')
+      .element('.auth-form-header2') // Wrong selector name
+      .getProperty('innerHTML');
+
+    browser.expect.element('.auth-form-header2').to.not.be.present.before(1000);
+
+    const chained = browser
+      .element('.invalid-selector')
+      .find('.another-invalid-selector')
+      .getText();
+
+    browser.expect(chained).to.be.null;
+
+    browser.expect.element('.non-existent-element').to.not.be.present.before(1000);
+  });
+
+  it('should abort test case when abortOnFailure is set', function (browser) {
+    browser.options.abortOnFailure = true; // Set abortOnFailure option
+
+    const result = browser
+      .waitForElementVisible('body')
+      .element('.auth-form-header2') // Wrong selector name
+      .getProperty('innerHTML');
+
+    browser.expect.element('.auth-form-header2').to.not.be.present.before(1000);
+
+    // This line should not be reached if the test case is aborted
+    browser.assert.fail('Test case should have been aborted');
+  });
+
+  after(function (browser) {
+    browser.end();
+  });
+});

lib/api/web-element/scoped-element.js

@@ -135,17 +135,18 @@ class ScopedWebElement {
     const webElements = await this.locateElements({parentElement, selector, timeout, retryInterval});
 
     if (webElements.length === 0) {
-      const err = new Error(`Cannot find element with "${selector}" selector in ${timeout} milliseconds.`);
+      const err = new Error(`Cannot find element with "${selector}" selector.`);
+      err.name = 'NoSuchElementError';
       this.reporter.registerTestError(err);
 
-      return;
+      return null;
     }
 
     if (index > webElements.length) {
       const err = new Error(`The index "${index}" is out of bounds for selector "${selector}".`);
       this.reporter.registerTestError(err);
 
-      return;
+      return null;
     }
 
     return webElements[index];
@@ -175,8 +176,7 @@ class ScopedWebElement {
 
         if (abortOnFailure) {
           this.reporter.registerTestError(narrowedError);
-          // TODO: find a way to reject here without unhandled promise rejection
-          // reject(narrowedError);
+          throw narrowedError;
         }
 
         return null;
@@ -323,8 +323,8 @@ class ScopedWebElement {
 }
 
 function createNarrowedError({error, condition, timeout}) {
-  return error.name === 'TimeoutError'
-    ? new Error(`Timed out while waiting for element "${condition}" to be present for ${timeout} milliseconds.`)
+  return error.name === 'NoSuchElementError'
+    ? new Error(`Cannot find element with "${condition}" selector.`)
     : error;
 }