Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isPresent command #4059

Closed
wants to merge 1 commit into from
Closed

Conversation

Jai0401
Copy link

@Jai0401 Jai0401 commented Feb 26, 2024

fixes: #4055
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Fix - #4055

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jaimin Godhani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@garg3133
Copy link
Member

@Jai0401 You cannot just copy-paste somebody else's work and present it as your own.

@garg3133 garg3133 closed this Feb 27, 2024
@Jai0401
Copy link
Author

Jai0401 commented Feb 27, 2024

@garg3133 Apologies for the misunderstanding. I want to acknowledge that I referenced PR no. #4038 without proper attribution, and I now understand that it's not allowed. I genuinely did not intend to present someone else's work as my own. I appreciate your guidance, and I assure you that I will be more careful and respectful of intellectual property in the future. Thank you for bringing this to my attention.

@Jai0401 Jai0401 deleted the Added_isPresent branch February 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing isPresent command in new Element API
3 participants