Added isPresent command
#4056
Added isPresent command
#4056
Conversation
|
Hey @garg3133 I have some questions that
|
You can check the codebase for similar instances of ShadowRoot being imported. |
There was a problem hiding this comment.
As I've said before also, please make sure that the code or command you're adding actually work before marking the PR for review (keep the PR as draft till then). The isPresent command won't work right now.
Also, as mentioned in the issue as well, for checking if an element is present or not, you just need to match it with WebElement and ShadowRoot.
| @@ -569,6 +569,13 @@ module.exports = class MethodMappings { | |||
| return element.isDisplayed(); | |||
| }, | |||
|
|
|||
| isElementPresent(webElementOrId) { | |||
| const element = this.getWebElement(webElementOrId); | |||
| const value = element.findElement(); | |||
There was a problem hiding this comment.
This is an invalid call, findElement should always contain an argument.
There was a problem hiding this comment.
I will re investigate this problem tomorrow
|
|
||
| it('test .element().isPresent() present', async function() { | ||
| MockServer.addMock({ | ||
| url: '/session/13521-10219-202/element/0/present', |
There was a problem hiding this comment.
/present endpoint is invalid, no such endpoint exists.
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
Added
isPresentcommandFix - #4055
features/my-new-featureorissue/123-my-bugfix);