Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix: waitForElementNotPresent #3599

Merged
merged 5 commits into from
May 9, 2023
Merged

Test fix: waitForElementNotPresent #3599

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
936769f
removed done callback to end the test, after an assertion
harshit-bs Feb 6, 2023
33da1f4
update testPageObjectWaitForElementNotPresent.js
harshit-bs Mar 1, 2023
f081b8f
removed done callback to end the test, after an assertion
harshit-bs Feb 6, 2023
c8739f7
increased timeout for a flaky test
harshit-bs Mar 8, 2023
6993fdd
Merge remote-tracking branch 'origin/main' into issue/test-fix-waitFo…
harshit-bs Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/src/cli/testServiceCreationFromCli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ const mockery = require('mockery');
const assert = require('assert');
const origPath = require('path');

describe('Service creation from cli.js', function() {
this.timeout(30000);
const IS_WINDOWS = process.platform === 'win32';

(IS_WINDOWS ? describe.skip : describe)('Service creation from cli.js', function() {
harshit-bs marked this conversation as resolved.
Show resolved Hide resolved
this.timeout(15000);

beforeEach(function() {
mockery.enable({useCleanCache: true, warnOnUnregistered: false});
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.