Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid closing of session according to end_session_on_fail #3595

Merged
merged 4 commits into from Feb 17, 2023
Merged

avoid closing of session according to end_session_on_fail #3595

merged 4 commits into from Feb 17, 2023

Conversation

gravityvi
Copy link
Member

@gravityvi gravityvi commented Feb 1, 2023 •
edited

Changes

  • avoid closing the session when end_on_session_fail is set to false
  • added logic to avoid reusing sessions in case of failure when end_on_session_fail is enabled
    • It would spawn a new session and reuse that if a failure is detected in the preceding test and will keep that session open.

Impact

@gravityvi gravityvi marked this pull request as ready for review February 10, 2023 12:58
@beatfactor beatfactor merged commit ee01ee6 into nightwatchjs:main Feb 17, 2023
harshit-bs pushed a commit to harshit-bs/nightwatch that referenced this pull request Mar 16, 2023
@gravityvi @harshit-bs
avoid closing of session according to end_session_on_fail (nightwatch…
1a1a223 
…js#3595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor Awaiting requested review from beatfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

end_session_on_fail stopped working in version 2.0.4
2 participants
@gravityvi @beatfactor