Fixes/new headless mode in chrome #3581
Conversation
| @@ -328,7 +328,7 @@ module.exports = class SeleniumCapabilities { | |||
|
|
|||
| addHeadlessOption({options}) { | |||
| if (this.argv.headless && (options instanceof Capabilities) && (this.isChrome || options.headless)) { | |||
| this.isChrome ? options.addArguments('headless=chrome') : options.headless(); | |||
| this.isChrome ? options.addArguments('headless=new') : options.headless(); | |||
There was a problem hiding this comment.
What about the older versions of Chrome browser? Would --headless=new work with them as well?
There was a problem hiding this comment.
There is no way to detect the version of the chrome browser before the driver creation. And people using older version of chrome will likely be using older version of nightwatch
There was a problem hiding this comment.
We should tag this as a breaking change
There was a problem hiding this comment.
But we can also detect the version of chromedriver, right? Since chromedriver version == chrome version.
(Of course, only if it is worth doing. But I guess we can also pass the --headless=chrome argument directly in desired capabilities and it will work for older chrome versions?)
Changes
--headless=newfrom--headless=chromeaccording to the recent change in chrome. For more details refer this issue