Added a check for 0 ms in pause command #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityvi
approved these changes
Jan 3, 2023
garg3133
reviewed
Jan 3, 2023
lib/api/client-commands/pause.js
Outdated
| @@ -42,7 +42,7 @@ Pause.prototype.command = function(ms, cb) { | |||
| // If we don't pass the milliseconds, the client will | |||
| // be suspended indefinitely, until the user presses some | |||
| // key in the terminal to resume it. | |||
| if (!ms) { | |||
| if (!ms && ms !== 0) { | |||
There was a problem hiding this comment.
Should we make it if (ms === undefined) { instead? Because that's only when we should pause indefinitely (if the first argument is undefined). If something else is passed as the first argument which is falsy (null, false for ex.), then we should just let it go to the else clause and let setTimeout through an error, instead of pausing indefinitely?
There was a problem hiding this comment.
Yes, Will make changes.
garg3133
approved these changes
Jan 4, 2023
|
Thanks, @garg3133 for your involvement in this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3422