Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/21 fixes #34

Closed
wants to merge 3 commits into from
Closed

Conversation

AkhilJ321
Copy link

Fixing the security vulnerability of packages by iteratively solving them.

Issue Related: #21

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

@AkhilJ321 Have you tested that moving appium-adb to v12 have no repercussions on the working of the tool?

Also, when you change something in package.json, running npm install makes the corresponding changes in package-lock.json as well. You can also just run commands like npm i -D nightwatch@3.4.1 to make changes in both package.json and package-lock.json in one go.

@AkhilJ321
Copy link
Author

AkhilJ321 commented Mar 6, 2024

@garg3133
Screenshot from 2024-03-06 15-50-15
This download has not been maintained for quite some time, so there isn't any proper fix for this, rather than manually updating package.lock.json but that is also not reliable.
This is the issue linked to this problem in their repo:
kevva/download#224

@AkhilJ321
Copy link
Author

AkhilJ321 commented Mar 6, 2024

@AkhilJ321 Have you tested that moving appium-adb to v12 have no repercussions on the working of the tool?

Also, when you change something in package.json, running npm install makes the corresponding changes in package-lock.json as well. You can also just run commands like npm i -D nightwatch@3.4.1 to make changes in both package.json and package-lock.json in one go.

Yes I ran the npm run test:unit command and it ran successfully

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

@AkhilJ321 Leave the download package for now, there's already an issue present to fix it: #12

@AkhilJ321
Copy link
Author

AkhilJ321 commented Mar 6, 2024

image
This is another issue which is dependent on the download package.
Other than this one critical issue is remaining.
Screenshot from 2024-03-06 21-52-48

There is no patched version for this package:
image

@AkhilJ321
Copy link
Author

@garg3133 ,Any reviews regarding this?

@garg3133
Copy link
Member

Ah, I completely forgot about this PR and made similar changes to the main branch directly, apologies for that. But good work on the PR. Thanks a lot!

@garg3133 garg3133 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants