Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace piscina with tinypool #82

Merged
merged 9 commits into from Nov 28, 2023
Merged

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Nov 27, 2023

Fixes #59

@fisker fisker mentioned this pull request Nov 27, 2023
4 tasks
@fisker fisker closed this Nov 27, 2023
@fisker fisker reopened this Nov 27, 2023
@fisker
Copy link
Contributor Author

fisker commented Nov 27, 2023

@nicolo-ribaudo
Copy link
Owner

Do you have any before/after for how long this takes to run Prettier's tests?

@fisker
Copy link
Contributor Author

fisker commented Nov 28, 2023

Since Prettier tests runs with --runInBand, so there is nothing to compare at all. I'll make it work for --maxWorkers first.

@fisker
Copy link
Contributor Author

fisker commented Nov 28, 2023

@nicolo-ribaudo
Copy link
Owner

Given that this does introduce perf regressions, I'm accepting the change given that it reduces the number of deps.

@nicolo-ribaudo
Copy link
Owner

Let me know if this is ready to merge, then I'll update the Babel tests :)

@fisker
Copy link
Contributor Author

fisker commented Nov 28, 2023

I think it's ready.

@nicolo-ribaudo nicolo-ribaudo merged commit e4aeb8c into nicolo-ribaudo:main Nov 28, 2023
4 of 5 checks passed
@fisker fisker deleted the tinypool branch November 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate using tinypool over piscina
2 participants