Fix t.isReferenced() for named re-exports (babel#12395)

nicolo-ribaudo · Dec 2, 2020 · a66f89c · a66f89c
1 parent 5d0adab
commit a66f89c
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 9 deletions.
diff --git a/packages/babel-types/src/validators/isReferenced.js b/packages/babel-types/src/validators/isReferenced.js
@@ -29,15 +29,6 @@ export default function isReferenced(
     case "ArrowFunctionExpression":
       return parent.body === node;
 
-    // no: export { foo as NODE };
-    // yes: export { NODE as foo };
-    // no: export { NODE as foo } from "foo";
-    case "ExportSpecifier":
-      if (parent.source) {
-        return false;
-      }
-      return parent.local === node;
-
     // no: class { #NODE; }
     // no: class { get #NODE() {} }
     // no: class { #NODE() {} }
@@ -120,6 +111,15 @@ export default function isReferenced(
     case "ExportDefaultSpecifier":
       return false;
 
+    // no: export { foo as NODE };
+    // yes: export { NODE as foo };
+    // no: export { NODE as foo } from "foo";
+    case "ExportSpecifier":
+      if (grandparent?.source) {
+        return false;
+      }
+      return parent.local === node;
+
     // no: import NODE from "foo";
     // no: import * as NODE from "foo";
     // no: import { NODE as foo } from "foo";

diff --git a/packages/babel-types/test/validators.js b/packages/babel-types/test/validators.js
@@ -247,6 +247,28 @@ describe("validators", function () {
         expect(t.isReferenced(node, parent)).toBe(false);
       });
     });
+
+    describe("exports", function () {
+      it("returns false for re-exports", function () {
+        const node = t.identifier("foo");
+        const parent = t.exportSpecifier(node, t.identifier("bar"));
+        const grandparent = t.exportNamedDeclaration(
+          null,
+          [parent],
+          t.stringLiteral("library"),
+        );
+
+        expect(t.isReferenced(node, parent, grandparent)).toBe(false);
+      });
+
+      it("returns true for local exports", function () {
+        const node = t.identifier("foo");
+        const parent = t.exportSpecifier(node, t.identifier("bar"));
+        const grandparent = t.exportNamedDeclaration(null, [parent]);
+
+        expect(t.isReferenced(node, parent, grandparent)).toBe(true);
+      });
+    });
   });
 
   describe("isBinding", function () {