Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the count of lines. #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct the count of lines. #266

wants to merge 1 commit into from

Commits on Nov 27, 2019

  1. Correct the count of lines. 

    The number of lines in a file is usually computed at the number of newlines in the file minus 1, as described [here](https://codereview.stackexchange.com/questions/131143/counting-newlines-in-a-file).  I also confirmed this by running `wc` on linux with a file that is:

* empty
* non-empty but with no newlines
* with newlines and no trailing newline
* with newlines and with a trailing newline

I noticed this when I saw that the number of lines reported in the file list on coveralls didn't match the number of lines actually in the file.
    @eyal0
    eyal0 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    8ad3607 View commit details
    Browse the repository at this point in the history