Upgrade to Rails 7 and swap Webpacker with esbuild #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires using Docker Compose 1.27+ but this specification unifies both v2 and v3.
nickjj
force-pushed
the
feature-rails-7-esbuild
branch
from
6761fea
to
a9a91ab
Compare
This is a big commit. The changelog sums most things up.
nickjj
force-pushed
the
feature-rails-7-esbuild
branch
from
a9a91ab
to
c2b0a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's lots of changes here. It goes from Rails 6.x / Webpacker 6 beta to Rails 7.0 with esbuild. The changelog sums up most high level changes. There were a few Rails 7 related changes based on the new generated app but overall these were tiny changes.
If you crawl through this diff I'm sure you'll be able to painlessly update your app.
One pending issue is Sidekiq doesn't start in production mode due to a zeitwerk related issue. That one is above my paygrade at the moment. I opened issue #30 here with more details.