Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Retry on timeout #106

Merged
merged 2 commits into from Dec 30, 2022
Merged

fix: Retry on timeout #106

merged 2 commits into from Dec 30, 2022

Conversation

trungnt2910
Copy link
Contributor

Replace the bullet points below with your answers

Description

  • Non-success exit codes are ignored for commands that have timed out and killed by this script, as processes that haven't terminated gracefully usually return a non-zero value.
  • A variable is used to track timeouts instead of the signal kind (SIGTERM) as Windows doesn't use signals for process termination.

Should fix #44.

Testing

@trungnt2910
fix: do not set return value for timed out runs
4a506cb 
Commands that are killed manually due to timeout rarely returns a
success status code (0). These codes should not be treated as errors
but simply produced because of the timeout.
@trungnt2910
fix(windows): use variable to track timeout
9685ccb 
Use a variable to track timeout instead of relying on SIGTERM, as
processes on Windows are not killed using signals.
@addshore addshore mentioned this pull request Dec 29, 2022
Closed
@nick-fields nick-fields merged commit 943e742 into nick-fields:master Dec 30, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-fields nick-fields nick-fields approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not retrying the command
2 participants
@trungnt2910 @nick-fields