Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Retry on timeout #106

Merged
merged 2 commits into from Dec 30, 2022
Merged

fix: Retry on timeout #106

merged 2 commits into from Dec 30, 2022

Commits on Oct 21, 2022

  1. fix: do not set return value for timed out runs 

    Commands that are killed manually due to timeout rarely returns a
success status code (0). These codes should not be treated as errors
but simply produced because of the timeout.
    @trungnt2910
    trungnt2910 committed Oct 21, 2022
    Copy the full SHA
    4a506cb View commit details
    Browse the repository at this point in the history

  2. fix(windows): use variable to track timeout 

    Use a variable to track timeout instead of relying on SIGTERM, as
processes on Windows are not killed using signals.
    @trungnt2910
    trungnt2910 committed Oct 21, 2022
    Copy the full SHA
    9685ccb View commit details
    Browse the repository at this point in the history