New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry only on specific exit code #58
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
961aa0f
feat: retry only on specific exit code
andersfischernielsen 4e441ea
feat: retry only on specific exit code
andersfischernielsen e19da5f
Run ci_cd on all push events
andersfischernielsen cf714f3
dedupe step IDs
nick-fields 679f4bb
add assertions for retry_on_exit_code tests
nick-fields 102009e
minor: implemented suggested fix from @andersfischernielsen
nick-fields 217d6c1
docs: update readme to reflect new retry_on_exit_code input
nick-fields File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andersfischernielsen @erwinw
Can you take a look at this test failure? I made a few tweaks to your tests, first being that a duplicate
id
was used which caused the entire workflow to fail, then I added assertions to your two tests.The assertion is failing for your
retry_on_exit_code (with unexpected error code)
test. I assert that if an unexpected exit code is thrown (exit code 1), and theretry_on_exit_code
is set (exit code 2), then the rerun should only occur once not 3x as is happening currently. I think you need to also handlemax_attempts
whenretry_on_exit_code
is set and skip additional attempts if an unexpected exit code is returned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nick-fields , well danged, I've
pokedgently asked @andersfischernielsen to have a look at this!