Storybook upgrade to 6.4 final #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
fredvisser
commented
Dec 3, 2021
rajsite
reviewed
Dec 3, 2021
rajsite
reviewed
Dec 3, 2021
| "@storybook/html": "^6.4.0", | ||
| "@storybook/jest": "^0.0.5", | ||
| "@storybook/manager-webpack5": "^6.4.0", | ||
| "@storybook/testing-library": "^0.0.7", |
There was a problem hiding this comment.
Are these new packages @storybook/jest and @storybook/testing-library intentional? Their comments talk about testing for React components which doesn't seem necessary for us
There was a problem hiding this comment.
I included both to use with the new Interactions add-on. We may choose not to use the jest component, but I'll give a demo next week to show the capabilities.
rajsite
reviewed
Dec 3, 2021
rajsite
requested changes
Dec 3, 2021
packages/nimble-components/src/icon-base/tests/icons.stories.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Dec 6, 2021
rajsite
approved these changes
Dec 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
We've been running Storybook 6.4 beta for awhile, but Storybook 6.4 recently went final.
👩💻 Implementation
Storytyping within the matrix storieslayout: 'fullscreen'parameter, to restore default Storybook padding around each control. Also, removed non-functionalpreview-head.htmlstyling.🧪 Testing
✅ Checklist