Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Angular code bring up for nimble-rich-text-viewer component #1336

Merged
merged 8 commits into from
Jul 14, 2023

Conversation

vivinkrishna-ni
Copy link
Contributor

@vivinkrishna-ni vivinkrishna-ni commented Jul 5, 2023

Pull Request

🤨 Rationale

This PR includes the angular integration for the nimble-rich-text-viewer component, and it is intended to make the component available to the Angular application which allows us to get started with the other features of comments dependent on this component.

👩‍💻 Implementation

  • Added directive and module for nimble-rich-text-viewer.
  • Added nimble-rich-text-viewer to the example client app.

Note: We will add the input properties and attributes once the support for the markdown parser and other functionality in the component ( #1335) is completed.

🧪 Testing

Added basic unit tests for the directive.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@vivinkrishna-ni vivinkrishna-ni marked this pull request as ready for review July 7, 2023 04:59
@vivinkrishna-ni vivinkrishna-ni changed the title Angular integration for nimble-rich-text-viewer component Initial Angular code bring up for nimble-rich-text-viewer component Jul 10, 2023
@rajsite
Copy link
Member

rajsite commented Jul 12, 2023

@atmgrifter00 and @suseendran-ni this PR is waiting on y'alls reviews

@vivinkrishna-ni
Copy link
Contributor Author

@atmgrifter00 and @suseendran-ni this PR is waiting on y'alls reviews

@rajsite, FYI @suseendran-ni is out of office and he'll be back only by next week. Can we bypass his review as other code owners approved it?

@rajsite rajsite enabled auto-merge (squash) July 13, 2023 20:54
@rajsite
Copy link
Member

rajsite commented Jul 13, 2023

@rajsite, FYI @suseendran-ni is out of office and he'll be back only by next week. Can we bypass his review as other code owners approved it?

@vivinkrishna-ni yep, their review was not blocking, notice that the status checks were met. The status checks are approved if there is a minimum of one approver but you should use your best judgement to know if you need to wait for additional approvers.

If you are confident that it is possible to merge you are able to do so, no override should be needed. I merged from main and turned on autocomplete but in the future if it's ready to merge and you have required approvals that you are aware of you can merge.

@rajsite rajsite merged commit 8d55141 into main Jul 14, 2023
7 checks passed
@rajsite rajsite deleted the users/vivin/rich-text-viewer-angular-integration branch July 14, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants