Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich text viewer | Implementation of markdown parser #1335

Merged
merged 45 commits into from
Jul 25, 2023
Merged

Rich text viewer | Implementation of markdown parser #1335

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
5a348d0
Implemented markdown parser and added markdown value API for viewer c…
vivinkrishna-ni Jun 30, 2023
53bc3ce
Change files
vivinkrishna-ni Jun 30, 2023
590a2c8
Removed tiptap/pm and added only pm-markdown and pm-model as some pac…
vivinkrishna-ni Jun 30, 2023
68b157c
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jun 30, 2023
698f22b
Resolved some of the PR comments
vivinkrishna-ni Jul 4, 2023
8b955cb
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 4, 2023
f625d25
Resolve linting errors
vivinkrishna-ni Jul 4, 2023
5db53e9
Added node polyfills to support punycode used in the markdown-it library
vivinkrishna-ni Jul 4, 2023
c7d4d23
Added append document fragment when setting the markdown value
vivinkrishna-ni Jul 5, 2023
b503590
Cleared the inner HTML and appended the rich text content to viewer c…
vivinkrishna-ni Jul 5, 2023
7d1b9ee
Run npm install in the root directory
vivinkrishna-ni Jul 7, 2023
a713cfd
Updated UI and added storybook matrix tests
vivinkrishna-ni Jul 10, 2023
bb0d76a
Resolved some of the PR comments
vivinkrishna-ni Jul 10, 2023
41531b7
Updated the styles for nodes in viewer component
vivinkrishna-ni Jul 10, 2023
09cc91e
Renamed 'markdown' and removed `fit-to-content` attribute.
vivinkrishna-ni Jul 12, 2023
4a421cf
Resolve linting errors
vivinkrishna-ni Jul 12, 2023
4ee7a61
Changes for resolving some of the comments
vivinkrishna-ni Jul 12, 2023
0704f4c
Resolving lint error
vivinkrishna-ni Jul 12, 2023
18061a9
Moved the type/markdown-it to dependencies from dev
vivinkrishna-ni Jul 12, 2023
68298ce
Fixed issue in setting the margin style for list paragraphs
vivinkrishna-ni Jul 12, 2023
035e583
Resolve linting error
vivinkrishna-ni Jul 12, 2023
e5cff56
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 13, 2023
b579ce0
Updated the name of the viewer function and removed id
vivinkrishna-ni Jul 14, 2023
d4d9fe1
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 14, 2023
a549149
Test commit to check whether methods work on Safari browsers
vivinkrishna-ni Jul 14, 2023
8533518
Revoked the previous test commit
vivinkrishna-ni Jul 14, 2023
1246017
Resolved some of the PR comments
vivinkrishna-ni Jul 17, 2023
9a0b11e
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 17, 2023
5816a66
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 18, 2023
edbec0a
Added aftereach in the unit test cases
vivinkrishna-ni Jul 18, 2023
ff08921
Added the null assertion for markdown observable
vivinkrishna-ni Jul 18, 2023
770a349
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 19, 2023
c520616
Updated and added few test cases for markdown strings. Updated the sp…
vivinkrishna-ni Jul 19, 2023
5757830
Updated few minor changes.
vivinkrishna-ni Jul 19, 2023
351cd1e
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 20, 2023
8eff4f6
Updated package-lock.json
vivinkrishna-ni Jul 20, 2023
a29a7f9
Changes for resolving some comments
vivinkrishna-ni Jul 20, 2023
14ab812
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 21, 2023
426ee92
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 21, 2023
0b22333
Enabled normalize setting back and updated test cases accordingly.
vivinkrishna-ni Jul 21, 2023
9927fc8
Merge branch 'users/vivin/viewer-markdown-parser-implementation' of h…
vivinkrishna-ni Jul 21, 2023
71f520f
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 21, 2023
247c156
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 22, 2023
e3d9d40
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 24, 2023
bc69fb9
Merge branch 'main' into users/vivin/viewer-markdown-parser-implement…
vivinkrishna-ni Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-99393253-07d1-4ec4-902b-41680bddd36e.json
View file
Open in desktop
@@ -0,0 +1,7 @@
{
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
rajsite marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"comment": "Implementation of markdown parser for converting markdown input to rich text content in the viewer",
vivinkrishna-ni marked this conversation as resolved.
Show resolved Hide resolved
"packageName": "@ni/nimble-components",
"email": "123377523+vivinkrishna-ni@users.noreply.github.com",
"dependentChangeType": "patch"
}
jattasNI marked this conversation as resolved.
Show resolved Hide resolved