Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Wireit for nimble-components build #1267

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 23, 2023

Pull Request

🀨 Rationale

I looked into a couple productivity tools for Innovation Day. I'm adding support for Wireit to manage build caching/dependencies for nimble-components package build.

πŸ‘©β€πŸ’» Implementation

  • added dev dependency on Wireit
  • converted 6 build-related commands in package.json to use Wireit
  • changed tsc compile to use incremental build (as recommended by Wireit docs)

πŸ§ͺ Testing

Ran build commands locally

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

.gitignore Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
packages/nimble-components/package.json Show resolved Hide resolved
@m-akinc m-akinc requested a review from jattasNI May 24, 2023 15:33
packages/nimble-components/package.json Outdated Show resolved Hide resolved
packages/nimble-components/package.json Outdated Show resolved Hide resolved
packages/nimble-components/package.json Outdated Show resolved Hide resolved
@m-akinc m-akinc requested a review from rajsite May 24, 2023 17:15
angular-workspace/package.json Show resolved Hide resolved
angular-workspace/package.json Show resolved Hide resolved
packages/nimble-components/package.json Show resolved Hide resolved
packages/nimble-tokens/package.json Show resolved Hide resolved
packages/nimble-components/package.json Show resolved Hide resolved
packages/nimble-components/package.json Show resolved Hide resolved
packages/nimble-blazor/package.json Show resolved Hide resolved
@m-akinc m-akinc requested a review from jattasNI May 26, 2023 19:08
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the build is fixed I'll try it one more time on my dev machine, but it looks great to me! πŸŽ†

@rajsite
Copy link
Member

rajsite commented Jul 25, 2023

I'm gonna move this to draft because it's a bit on the backburner for now and would likely need to be updated to resolve conflicts. Think a good time to revive would be another innovation day.

@m-akinc may be useful to split out the karma stuff in a separate review if that plugin is generally useful for the team. The wire-it stuff is a bigger change I want to have to to double check thoroughly before pushing out to everyone.

@rajsite rajsite marked this pull request as draft July 25, 2023 22:49
@m-akinc m-akinc marked this pull request as ready for review December 14, 2023 00:23
@m-akinc m-akinc changed the title Use Wireit for nimble-components build and support Karma Test Explorer extension Use Wireit for nimble-components build Jan 2, 2024
@rajsite rajsite self-assigned this Feb 28, 2024
@@ -121,3 +121,6 @@ package-lock.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed yesterday moving to draft and assigning to myself to take a look in the future.

@rajsite rajsite marked this pull request as draft February 28, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants