Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): replace animationFrameScheduler with requestAnimationFrame #3592

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

animationFrameScheduler can stop working unexpectedly. See ReactiveX/rxjs#7018 for more info.

Closes #3591

What is the new behavior?

animationFrameScheduler is replaced with the native requestAnimationFrame API to solve potential bugs caused by the issue with animationFrameScheduler.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Sep 29, 2022

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 773196a
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6335b440c35c52000984b4d6
😎 Deploy Preview https://deploy-preview-3592--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@timdeschryver timdeschryver merged commit 0a4d2dd into ngrx:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgrxLet animationFrameScheduler can stop working
3 participants