feat: update Angular packages to version 13.0.0 #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
added
Breaking Change
Blocked (External)
|
Preview docs changes for fd1ae98 at https://previews.ngrx.io/pr3184-fd1ae986/ |
brandonroberts
force-pushed
the
angular-v-13
branch
from
8989a3d
to
35de9c1
Compare
3 tasks
brandonroberts
force-pushed
the
angular-v-13
branch
from
35de9c1
to
e0291a5
Compare
brandonroberts
force-pushed
the
angular-v-13
branch
from
4d7d376
to
41e8ddf
Compare
brandonroberts
force-pushed
the
angular-v-13
branch
from
7366517
to
799003d
Compare
brandonroberts
changed the title
timdeschryver
approved these changes
Nov 9, 2021
| @@ -5,7 +5,7 @@ | |||
| "experimentalDecorators": true, | |||
| "moduleResolution": "node", | |||
| "downlevelIteration": true, | |||
| "outDir": "../../dist/modules/schematics-score", | |||
There was a problem hiding this comment.
I actually liked the name schematics-score 👀
There was a problem hiding this comment.
Schematics do score, don't they 😄
package.json
Outdated
| "npm-run-all": "^4.1.5", | ||
| "nyc": "^10.1.2", | ||
| "ora": "^1.3.0", | ||
| "postcss": "^8.3.9", |
There was a problem hiding this comment.
Out of interest, why where these imports added?
There was a problem hiding this comment.
These were added with the Nx upgrade as far as I know, but we shouldn't need them
| @@ -31,6 +31,7 @@ | |||
| "bazel:lint": "yarn bazel:format --lint=warn", | |||
| "bazel:lint-fix": "yarn bazel:format --lint=fix", | |||
| "copy:schematics": "ts-node ./build/copy-schematics-core.ts", | |||
| "schematics:check": "git diff --name-only --exit-code ./modules", | |||
There was a problem hiding this comment.
Was the intention to use this script in the CI?
If it was, then I think we forgot to update the config.yml 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3189
What is the new behavior?
The minimum version of Angular has changed
BEFORE:
The minimum version of Angular is 12.x
AFTER:
The minimum version of Angular is 13.x
Does this PR introduce a breaking change?
Other information
Blocked on thymikee/jest-preset-angular#1090