Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set go_version in linting #99

Merged
merged 1 commit into from Apr 11, 2022
Merged

chore: Set go_version in linting #99

merged 1 commit into from Apr 11, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

We need to run the setup-go action as part of the lint job for v3 of the golint action to work (this was previously bundled with the golint action but has since been removed - see golangci/golangci-lint-action#403).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 merged commit 24232f1 into main Apr 11, 2022
@ciarams87 ciarams87 deleted the fix-linting branch April 11, 2022 15:05
@pammecrandall pammecrandall added the enhancement New feature or request label Aug 9, 2022
@lucacome lucacome added enhancement New feature or request chore Pull requests for routine tasks and removed enhancement New feature or request labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants