Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for golangci-lint errors #1751

Merged
merged 2 commits into from Mar 21, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 21, 2024

Proposed changes

Problem: golangci-lint is throwing hundreds of errors on setup, making it hard to see the actual run and slowing down the UI

Solution: The community found a workaround in golangci/golangci-lint-action#135, disabling pkg cache, which seems to be working without affecting performance.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 21, 2024
@lucacome lucacome marked this pull request as ready for review March 21, 2024 17:20
@lucacome lucacome requested a review from a team as a code owner March 21, 2024 17:20
@lucacome lucacome merged commit 90fc1a8 into nginxinc:main Mar 21, 2024
40 checks passed
@lucacome lucacome deleted the chore/golangci-lint-error branch March 21, 2024 17:40
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants