Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup version #1227

Closed
gund opened this issue Feb 27, 2019 · 1 comment · Fixed by #1233
Closed

Update rollup version #1227

gund opened this issue Feb 27, 2019 · 1 comment · Fixed by #1233
Labels

Comments

@gund
Copy link

gund commented Feb 27, 2019

Type of Issue

[ ] Bug Report
[x] Feature Request

Description

Current version of rollup being used has a major flaw in flat module bundles as it does not rename most of the reserved words (only undefined) in import statements (see rollup/rollup#2680).

That issue was addressed in rollup@1.2.0 via rollup/rollup#2689.

So my question is can ng-packagr update it's version of rollup so we can have proper FESM bundles?

How To Reproduce

See this example to understand the problem.

Expected Behaviour

FESM bundles should be properly flattened via newest version of rollup.

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr:            4.7.1
@angular/compiler:     7.2.6
rollup:                0.67.4
tsickle:               0.34.3
typescript:            3.2.4
node: 11.9.0
npm: 6.5.0
rollup: 0.67.4 (from package-lock.json file)
@github-actions
Copy link

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

2 participants