Remind us to promote the canary to production #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These credentials/this file shouldn't linger around between runner jobs anyway, but since we're explicitly cleaning up to be extra safe, let's do it right.
nextstrain-bot
temporarily deployed
to
nextstrain-s-trs-remind-vgyxwj
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
b95ef26
to
241300f
Compare
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
241300f
to
32cf1a3
Compare
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
32cf1a3
to
1bd2683
Compare
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
1bd2683
to
03f2d5d
Compare
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
03f2d5d
to
e527f9b
Compare
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
3ea4f4b
to
72890a4
Compare
victorlin
reviewed
Oct 21, 2022
…if we're tardy about it.
… period I think this will let us use a shorter grace period without being as annoying (e.g. not harping immediately on Monday about a Friday canary deploy). A little fuzzy on how this will interact with timezones as I haven't fully sketched that out for myself… but I think it's reasonable.
tsibley
force-pushed
the
trs/remind-to-promote
branch
from
c6c1ed6
to
143418a
Compare
Mark entire scripts as ok to use development dependencies instead of marking individual development dependencies as completely ignored by import/no-extraneous-dependencies. The upshot of this is that we'll still catch use of dependencies that aren't declared at all. Linting now passes for scripts/remind-to-remote.js.
victorlin
approved these changes
Oct 24, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…if we're tardy about it.
Changes outside PR
read-protectedscoped Heroku API token for our Heroku bot userHEROKU_TOKEN_READ_PROTECTEDGitHub org-level secret for ActionsSLACK_TOKENGitHub org-level secret for ActionsTesting