Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--input-pcr-primers listed in CLI help options despite being removed in v3 #1432

Open
kapsakcj opened this issue Apr 4, 2024 · 2 comments
Open
Labels
good first issue Good for newcomers help wanted Extra attention is needed t:bug Type: bug, error, something isn't working

Comments

@kapsakcj
Copy link

kapsakcj commented Apr 4, 2024

Just want to report that the --input-pcr-primers option for nextclade run is listed in the help options. According to migration docs here: https://docs.nextstrain.org/projects/nextclade/en/stable/user/migration-v3.html#some-cli-arguments-for-individual-input-files-are-removed this option has been removed.

Is it still available as an option? or perhaps just an oversight on the CLI help options?

I don't need to use this option, just wanted to let you know.

to reproduce:

$ docker run --rm nextstrain/nextclade:3.3.1 nextclade run --help | grep -A 4 'pcr-primers'
      --input-pcr-primers <INPUT_PCR_PRIMERS>
          Path to a CSV file containing a list of custom PCR primer sites. This information is used to report mutations in these sites.
          
          Supports the following compression formats: "gz", "bz2", "xz", "zstd". Use "-" to read uncompressed data from standard input (stdin).
@kapsakcj kapsakcj added good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment t:bug Type: bug, error, something isn't working labels Apr 4, 2024
@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Apr 4, 2024

@kapsakcj Hi Curtis,

Indeed. The functionality has been partially restored in 3.1.0 (#1398) due to popular demand (#1388). The docs need to be fixed.

@ivan-aksamentov ivan-aksamentov removed the needs triage Mark for review and label assignment label Apr 4, 2024
@kapsakcj
Copy link
Author

kapsakcj commented Apr 4, 2024

Ah ok, thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed t:bug Type: bug, error, something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants