Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppression of |(reverse complement) suffix in header of alignment output #1378

Open
corneliusroemer opened this issue Jan 10, 2024 · 2 comments
Labels
t:feat Type: request of a new feature, functionality, enchancement

Comments

@corneliusroemer
Copy link
Member

When --retry-reverse-complement is passed and a reverse complement is aligned, we add a |(reverse complement) suffix to the FASTA header of the affected sequence.

This can cause issues when matching sequences with metadata, as some scripts within augur expect the entire header to be unchanged.

It would be helpful if we offered the option to suppress the suffix. Workaround for now is for example a sed one-liner, though it's not so ergonomic to do this for all translations as well.

@corneliusroemer corneliusroemer added t:feat Type: request of a new feature, functionality, enchancement good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels Jan 10, 2024
@ivan-aksamentov ivan-aksamentov removed needs triage Mark for review and label assignment good first issue Good for newcomers help wanted Extra attention is needed labels Jan 10, 2024
@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jan 10, 2024

That's exactly why I was against adding a suffix back then! :)

On the other hand, we emit results for another sequence, against usual expectations, and it's not manifested particularly loud.

Could you please propose how that feature would look like?

@corneliusroemer
Copy link
Member Author

Maybe something like: --reverse-complement-suffix true/false or alternatively --no-reverse-complement-suffix/--add-reverse-complement-suffix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feat Type: request of a new feature, functionality, enchancement
Projects
None yet
Development

No branches or pull requests

2 participants