Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutations relative to different references #1237

Open
rneher opened this issue Aug 11, 2023 · 1 comment
Open

Mutations relative to different references #1237

rneher opened this issue Aug 11, 2023 · 1 comment
Labels
t:feat Type: request of a new feature, functionality, enchancement

Comments

@rneher
Copy link
Member

rneher commented Aug 11, 2023

We currently report mutations relative to the reference sequences and relative to the nearest node in the reference tree, called private mutations. The former are derived straight from the alignment, the latter are deduced by comparing the full set of differences to the set of differences the attachment node in the tree has. This happens here in the code:

let private_nuc_mutations = find_private_nuc_mutations(
nearest_node,
&substitutions,
&deletions,
&missing,
&alignment_range,
ref_seq,
&non_acgtns,
virus_properties,
);
let GatherAaAlignmentRangesResult {
aa_alignment_ranges,
aa_unsequenced_ranges,
} = gather_aa_alignment_ranges(&translation, gene_map);
let private_aa_mutations = find_private_aa_mutations(
nearest_node,
&aa_substitutions,
&aa_deletions,
&unknown_aa_ranges,
&aa_unsequenced_ranges,
ref_peptides,
gene_map,
);

We could repeat this for different nodes in the tree, for example vaccines strains for flu. Instead of passing nearest_node to the find_private_mutations functions, we can pass any other node.

In some cases, it could also be interesting to display mutations relative to the founder of the parent clade. In this case the the node we compare to would be dependent on the clade assignment of the node.

In the UI, once could move the mutations column to the right next to the sequence view and thereby separate it from the other properties that are independent of the point of comparison.

image

A toggle could allow switching between different options (e.g. reference, VaccineStrain2023, clade_parent) and would also update the sequence view.

@rneher rneher added t:feat Type: request of a new feature, functionality, enchancement good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels Aug 11, 2023
@ivan-aksamentov ivan-aksamentov removed needs triage Mark for review and label assignment good first issue Good for newcomers help wanted Extra attention is needed labels Aug 11, 2023
@rneher rneher changed the title Mutations relative to difference references Mutations relative to different references Aug 11, 2023
@ivan-aksamentov
Copy link
Member

Slack thread for more context: https://neherlab.slack.com/archives/C015PFP5V44/p1691781214598009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feat Type: request of a new feature, functionality, enchancement
Projects
No open projects
Development

No branches or pull requests

2 participants