Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Show private aa substitutions in mutations tooltip #1142

Open
corneliusroemer opened this issue May 2, 2023 · 1 comment
Open

ENH: Show private aa substitutions in mutations tooltip #1142

corneliusroemer opened this issue May 2, 2023 · 1 comment
Labels
package: nextclade_web t:feat Type: request of a new feature, functionality, enchancement

Comments

@corneliusroemer
Copy link
Member

The private mutations tooltip (labeled, reversions, unlabeled) is extremely useful. It currently only shows nucleotide substitutions. I think this is partially because nucleotide substitutions are "simpler" and usually more informative for QC than aa substitutions, also not all nucleotide mutations cause aa substitutions. So it makes sense that we use nucleotide substitutions as the fundamental unit in the mutations tooltip.

However, when reviewing SARS-CoV-2 sequences for new developments (not for QC purposes), it is usually the amino acid substitutions that are of primary interest. I often find myself having to look up which aa substitution (if any) a particular new nucleotide substitution corresponds to. I've by now learned a few nt substitutions of by heart (e.g. S:346T is 22599) but it's not an ideal solution to require memorization/lookup.

It would be great if we could also report aa substitutions, besides nt substitutions.

There are a few design decisions to be made but it shouldn't be impossible. One idea would be to have two mutation columns: one for nucleotides and one for amino acids. Right now, we show both together, but only nt have the "private" feature. This would give us more space to show more nt mutations (sometimes truncated, see below). A reason to report nt and aa together is that we could match nt and aa substitions. But we don't do this currently (and it's not trivial).

An alternative way to create more space would be to report "all mutations" and "private mutations" in different columns. A lot of space is taken up by "all mutations" - that way aa and nt could stay together, just grouped by topic.

Having a separate column (whether "aa" in addition to existing "nt" or "private" in addition to "all") would also add a new way to sort the table which could be useful.

Example of current mutation tooltip:
image

@corneliusroemer corneliusroemer added t:feat Type: request of a new feature, functionality, enchancement needs triage Mark for review and label assignment package: nextclade_web labels May 2, 2023
@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented May 2, 2023

I think this should be relatively straightforward to add, the find_private_nuc_mutations.rs is mostly the same as find_private_aa_mutations.rs, except AA version runs multiple times for each gene.

Private AA subs and dels are already calculated, so we just need to write a UI for them.

Labelling of mutations can also be implemented if needed, but that would require additional data in virus properties JSON.

@ivan-aksamentov ivan-aksamentov removed the needs triage Mark for review and label assignment label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: nextclade_web t:feat Type: request of a new feature, functionality, enchancement
Projects
No open projects
Development

No branches or pull requests

2 participants