Update link to pandas DataFrame query doc #872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section ID on the docs is now `the-query-method`. The ID `indexing-query` is on an invisible `span` element. It was probably an older section ID that's kept around on the span to make sure existing links still work. Updating the link to the new ID selector in case the empty span gets removed in the future.
tsibley
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Ah, I think we should leave this as-is.
The "invisible span" with indexing-query is an explicit target/anchor in the source rST document and is intended as a stable cross-ref name. The "visible" section id of the-query-method arises from the implicit target/anchor created by the rST heading, which won't be stable over time if the heading text changes.
.. _indexing.query:
The :meth:`~pandas.DataFrame.query` Method
------------------------------------------
|
Ohh thanks for digging that up! Agree to leave it as-is then. |
|
I only thought to go look because having looked at the DOM of some Sphinx pages recently I'd noticed those empty spans with an id and knew what they corresponded to in the source docs I was using. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section ID on the docs is now
the-query-method. The IDindexing-queryis on an invisiblespanelement. It was probably an older section ID that's kept around on the span to make sure existing links still work. Updating the link to the new ID selector in case the emptyspangets removed in the future.