Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sorting by date and number #2318

Merged
merged 1 commit into from May 23, 2024
Merged

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented May 13, 2024

Reproduction:
Case Date

  1. Sort files by modification date (asc/desc)
  2. open viewer
  3. navigate between files
  4. Wrong sorting order

Case Number

  1. Sort files by modification File size (desc)
  2. open viewer
  3. navigate between files
  4. Wrong sorting order

@hamza221 hamza221 requested a review from skjnldsv May 13, 2024 14:53
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels May 13, 2024
@hamza221
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 13, 2024
@hamza221
Copy link
Contributor Author

/backport to stable29

@hamza221 hamza221 force-pushed the Fix/date-and-number-sorting branch 2 times, most recently from 7c0bb68 to ed3248a Compare May 13, 2024 15:18
@hamza221 hamza221 self-assigned this May 13, 2024
@hamza221
Copy link
Contributor Author

@skjnldsv
Not sure how to fix the cypress job Error response from daemon: No such container: nextcloud-cypress-tests-viewer

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@skjnldsv skjnldsv force-pushed the Fix/date-and-number-sorting branch from ed3248a to 2d67ddd Compare May 23, 2024 08:01
@skjnldsv skjnldsv merged commit 092dd8c into master May 23, 2024
25 of 30 checks passed
@skjnldsv skjnldsv deleted the Fix/date-and-number-sorting branch May 23, 2024 08:21
@skjnldsv
Copy link
Member

Not you, something needs to be fixed on the cypress tests

Copy link

backportbot bot commented May 23, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2318/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d67ddda

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2318/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants