Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NcRichText component from @nextcloud/vue #3859

Merged
merged 4 commits into from Mar 2, 2023

Conversation

julien-nc
Copy link
Member

🎉 Circular dependency is definitely going down with the next @nextcloud/vue release which will includes NcRichText and everything needed for the link picker and the reference widgets.

refs nextcloud-libraries/nextcloud-vue#3841 nextcloud-libraries/nextcloud-vue#3812

I'll update @nextcloud/vue and set this to "ready for review" once the new release is out.

@julien-nc
Copy link
Member Author

/compile

@julien-nc julien-nc marked this pull request as ready for review March 2, 2023 12:38
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we import files from @nextcloud/vue/dist/.* now, we need to add a rule to vite.config.js:

diff --git a/vite.config.js b/vite.config.js
index 0b7885ce8..a1ee24e76 100644
--- a/vite.config.js
+++ b/vite.config.js
@@ -21,6 +21,7 @@ export default defineConfig({
                                /markdown-it\/.*/,
                                /@tiptap\/pm\/.*/,
                                /vue-material-design-icons\/.*/,
+                               /@nextcloud\/vue\/.*/,
                        ],
                        output: {
                                globals: { vue: 'Vue' },

If you want me to, I can push a commit to this PR.

@cypress
Copy link

cypress bot commented Mar 2, 2023

1 flaky tests on run #8826 ↗︎

0 139 0 0 Flakiness 1

Details:

Use NcRichText component from `@nextcloud/vue`
Project: Text Commit: 36b6ac8fff
Status: Passed Duration: 03:27 💡
Started: Mar 2, 2023 3:19 PM Ended: Mar 2, 2023 3:22 PM
Flakiness  cypress/e2e/share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@julien-nc
Copy link
Member Author

@mejo- I don't exactly know the implications of doing that but fully trust your judgement 😁.
Yes you can add a commit to this PR.

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@mejo- mejo- force-pushed the enh/noid/use-richtext-from-ncvue branch 2 times, most recently from 2c4f40b to 31ccd5a Compare March 2, 2023 15:01
@mejo-
Copy link
Member

mejo- commented Mar 2, 2023

@mejo- I don't exactly know the implications of doing that but fully trust your judgement grin. Yes you can add a commit to this PR.

The reason for that is that we only treat imports that exactly match names of our dependencies from package.json as external in vite per default - all other imports lead to the imported files are vendored into the resulting JS asset by vite build. Therefore we need to list regexes for direct imports of files from our dependencies explicitely. See PR #3821 for further details.

@mejo-
Copy link
Member

mejo- commented Mar 2, 2023

I rebased on current main and pushed my commit.

@mejo-
Copy link
Member

mejo- commented Mar 2, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@julien-nc julien-nc merged commit 81ddeff into main Mar 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/use-richtext-from-ncvue branch March 2, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants