Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement repeating tasks #2318

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

feat: implement repeating tasks #2318

wants to merge 14 commits into from

Conversation

raimund-schluessler
Copy link
Member

No description provided.

@raimund-schluessler raimund-schluessler mentioned this pull request Aug 17, 2023
Closed
@raimund-schluessler raimund-schluessler linked an issue Aug 17, 2023 that may be closed by this pull request
[Feature Request] Repeating tasks #34
Open
@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited

Codecov Report

Merging #2318 (5d844c0) into master (5f6f5b5) will increase coverage by 0.08%.
Report is 170 commits behind head on master.
The diff coverage is 9.14%.

❗ Current head 5d844c0 differs from pull request most recent head 2c6314e. Consider uploading reports for the commit 2c6314e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
+ Coverage   24.87%   24.96%   +0.08%     
==========================================
  Files          63       69       +6     
  Lines        2388     3409    +1021     
  Branches      257      780     +523     
==========================================
+ Hits          594      851     +257     
- Misses       1776     2558     +782     
+ Partials       18        0      -18

@sunkup sunkup force-pushed the 34-feature-request-repeating-tasks branch 2 times, most recently from 452b599 to 1cdc0f4 Compare August 20, 2023 08:46
meichthys
meichthys reviewed Aug 31, 2023
View reviewed changes
src/models/task.js Outdated Show resolved Hide resolved
@sunkup sunkup force-pushed the 34-feature-request-repeating-tasks branch from 1cdc0f4 to d59d017 Compare September 1, 2023 11:01
meichthys
meichthys reviewed Sep 28, 2023
View reviewed changes
Copy link

@meichthys meichthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start!
Thanks @sunkup for your work on this 👍

@sunkup sunkup force-pushed the 34-feature-request-repeating-tasks branch 2 times, most recently from 3a7732d to 5d844c0 Compare October 8, 2023 17:18
@sunkup sunkup marked this pull request as draft October 8, 2023 19:13
@sunkup sunkup force-pushed the 34-feature-request-repeating-tasks branch from 0033461 to 8ffefcc Compare November 10, 2023 13:24
@sunkup sunkup force-pushed the 34-feature-request-repeating-tasks branch from 8ffefcc to 2f756ce Compare December 10, 2023 11:42
@raimund-schluessler
Copy link
Member Author

@sunkup I rebased to current master.

@raimund-schluessler raimund-schluessler mentioned this pull request Jan 31, 2024
Merged
@raimund-schluessler raimund-schluessler linked an issue Feb 1, 2024 that may be closed by this pull request
Completing recurring task destroys recurrance. #2276
Open
@raimund-schluessler raimund-schluessler changed the title Repeating tasks feat: implement repeating tasks Feb 1, 2024
@sunkup @raimund-schluessler
Show repeat icon for recurring tasks
5994189 
Signed-off-by: Sunik Kupfer <mail@sunik.de>
Signed-off-by: Sunik <mail@sunik.de>
Signed-off-by: Sunik Kupfer <mail@sunik.de>
@sunkup @raimund-schluessler
Complete recurring tasks by setting their start date to the next recu…
edebf8d 
…rrence date

Signed-off-by: Sunik Kupfer <mail@sunik.de>
Signed-off-by: Sunik <mail@sunik.de>
Signed-off-by: Sunik Kupfer <mail@sunik.de>
@sunkup @raimund-schluessler
Add initial unfinished repeat item to sidebar
be6696c 
Signed-off-by: Sunik <mail@sunik.de>
Signed-off-by: Sunik Kupfer <mail@sunik.de>
@sunkup @raimund-schluessler
Display recurrence summary
ec6bef4 
Signed-off-by: Sunik <mail@sunik.de>
Signed-off-by: Sunik Kupfer <mail@sunik.de>
@sunkup @raimund-schluessler
Add toggle options button
4705250 
Signed-off-by: Sunik Kupfer <mail@sunik.de>
@raimund-schluessler
feat: move repeat item into own tab
79bca94 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler linked an issue Feb 1, 2024 that may be closed by this pull request
Due date of repeating tasks not updated in NC Tasks GUI after completion in Thunderbird #316
Open
@arunas-smala
Copy link

arunas-smala commented Feb 7, 2024 •
edited

Any plans to finish it? Any help needed?

@sunkup
Copy link

sunkup commented Feb 8, 2024

Any plans to finish it? Any help needed?

Please, feel free. I don't really get to work on this more any time soon 👍

@bobiko
Copy link

bobiko commented Mar 11, 2024

What is the status of ? from what I see, it's stuck on a synchronization problem

@sunkup
Copy link

sunkup commented Mar 12, 2024

What is the status of ?

I am learning Vue, but very slowly ...

from what I see, it's stuck on a synchronization problem

I am stuck, haha. Right here. If you know how to fix that I might be able to continue :)

@marcoambrosini marcoambrosini mentioned this pull request Mar 14, 2024
Open
@meichthys
Copy link

@jancborchardt Do you think the Nextcloud Groupware or Tasks teams could provide a helping hand to get this over the finish line? It's one of the oldest (from Nextcloud v9) and as far as I can see, it is the most requested feature in all of nextcloud by a significant margin (379 👍) As a longtime user of Nextcloud (and tasks), I've taken a few shots at implementing this myself, but haven't gotten anywhere as close as this draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup left review comments

@meichthys meichthys meichthys left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2 - developing enhancement feature
Projects
None yet
Milestone
No milestone
5 participants
@raimund-schluessler @arunas-smala @sunkup @bobiko @meichthys