Implemented Google EmojiPicker #3439

Smarshal21 · 2023-11-08T19:04:11Z

Resolves #2735

Description:

This pull request is aimed at replacing the existing Vanniktech Emoji Picker with the Google EmojiPicker within our application. The primary objectives of this change are to enhance the user experience and maintain compatibility with current emoji standards and features.

Changes Made:

Removed the Vanniktech Emoji Picker integration from the application.
Integrated the Google EmojiPicker into the application.
Ensured that all relevant functionality remains consistent after the replacement.

Screenshots:

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed.
🔖 Capability is checked or not needed.
🔙 Backport requests are created or not needed: /backport to stable-xx.x.
📅 Milestone is set.
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?).

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

…alog Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Smarshal21 · 2023-11-08T19:05:35Z

@mahibi and @AndyScherzinger could you please look into this pr and let me know
and there are some usecases of vanniktech library which cant be replace with emoji2 library so i haven't changed them

AndyScherzinger · 2023-11-08T19:13:41Z

@Smarshal21 Afaik the former solution also allowed to search for emojis (not too important to have IMHO). Is this possible with the Google lib?

Smarshal21 · 2023-11-08T19:44:11Z

Afaik

Afaik No, If yes will take a look at it but didn't find it in this LIb

rapterjet2004 · 2023-11-09T15:16:30Z

ctrl + shift + r shows that there are still more instances of com.vanniktech.emoji in the project.

Smarshal21 · 2023-11-09T15:36:22Z

`ctrl` + `shift` + `r` shows that there are still more instances of `com.vanniktech.emoji` in the project.

yeah here are some usecases of vanniktech library which cant be replaced with emoji2 library so i haven't changed them,
should i remove every instance of vanniktech??

rapterjet2004 · 2023-11-09T16:06:37Z

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

Smarshal21 · 2023-11-09T16:09:40Z

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

Sure Will do it

Smarshal21 · 2023-11-09T20:49:42Z

@rapterjet2004 could you let me know if the remaining instances of vanniktech are useful/important i find its to better to remove those as i dont find any usecases of it
correct me if am wrong

mahibi · 2023-11-10T11:41:18Z

The goal is to remove the vanniktech lib completely.
So you could just remove it from build.gradle and try to implement everything with the google lib instead.

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

rapterjet2004

Looks good! Just clear up those code quality checks. You can run .\gradlew detekt or .\gradlew ktlintCheck in the android terminal to check them locally. As for Codacy and Analysis, you'll have to check out the web gui Here

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

mahibi · 2023-11-16T16:47:48Z

app/src/main/res/layout/dialog_set_status.xml

+        android:layout_width="match_parent"
+        android:visibility="gone"
+        android:layout_height="match_parent"
+        app:emojiGridColumns="9" />


app:emojiGridColumns="9" is too much here. The emojis are too small on my device (Galaxy a32).
If it can't be flexible depending of the available width, 7 columns worked for me best on this device.
But this might need some tinkering to look good on all devices.

https://developer.android.com/guide/topics/large-screens/support-different-screen-sizes

Would this be a better solution @mahibi ???

sorry, oversaw this..
sure, calculating on screen values would work.
But we can also go with a fixed value for now and gain some feedback on test releases (this PR won't be available for 18.0.0, so enough time get feedback..).
If people complain, the calculation can be added later..

does 7 work then???

sure, lets set 7 for now

mahibi · 2023-11-16T16:50:45Z

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

@@ -1429,30 +1427,17 @@ class ChatActivity :
    private fun initSmileyKeyboardToggler() {


the keyboard toggler is somehow broken with the new solution. It's now possible to show the emoji picker and the keyboard at the same timebelow it, which is a bit confusing.

mahibi

Thank you smarshal 👍
In the code i left some comments where things are broken.
Just let us know if you need help with this.

…ex for single emoji check Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in> updated license header Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com> Update dialog_create_conversation.xml Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com> Update dialog_create_conversation.xml Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

github-actions · 2023-12-16T15:23:20Z

Codacy

Lint

Type	master	PR
Warnings	83	84
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

Lint increased!

github-actions · 2023-12-16T15:28:00Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3439-talk.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Smarshal21 · 2023-12-18T13:07:36Z

@mahibi @rapterjet2004 resolved the changes requested👍🏻

mahibi · 2024-01-09T14:19:26Z

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now.
I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state.
And clicking on it should switch between the emoji view and keyboard.

Smarshal21 · 2024-02-09T20:53:50Z

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now. I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state. And clicking on it should switch between the emoji view and keyboard.

as far as i see its working fine i can toggle between them.

github-actions · 2024-03-31T02:03:46Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Smarshal21 added 5 commits November 8, 2023 18:06

Replaced EmojiPicker in SetStatusDialogFragment

ee601bb

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Replaced EmojiPicker in MessageActionsDialog and CreateConversationDi…

33ff8c4

…alog Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Replaced EmojiPicker in MessageActionsDialog and CreateConversationDi…

70e3ac3

…alog Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Replaced EmojiPicker in RenameConversationDialogFragment

ed3117b

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Replaced EmojiPicker in ChatActivity

d6ff39a

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Smarshal21 requested review from mahibi and AndyScherzinger and removed request for mahibi November 8, 2023 19:04

Smarshal21 mentioned this pull request Nov 8, 2023

replace emojipicker #2735

Open

1 task

AndyScherzinger requested a review from rapterjet2004 November 8, 2023 19:12

AndyScherzinger added this to the 18.0.0 milestone Nov 8, 2023

AndyScherzinger added the 3. to review Waiting for reviews label Nov 8, 2023

Smarshal21 changed the title ~~Replaced Vanniktech Emoji Picker with Google EmojiPicker~~ Implemented Google EmojiPicker Nov 9, 2023

rapterjet2004 closed this Nov 9, 2023

rapterjet2004 reopened this Nov 9, 2023

removed the instances of vanniktech

ec1108c

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

rapterjet2004 requested changes Nov 13, 2023

View reviewed changes

Smarshal21 added 2 commits November 14, 2023 14:23

Fixed Codacy errors

c173c70

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Fixed ktlintCheck

ac030a2

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Smarshal21 self-assigned this Nov 15, 2023

mahibi reviewed Nov 16, 2023

View reviewed changes

mahibi requested changes Nov 16, 2023

View reviewed changes

Smarshal21 and others added 6 commits November 18, 2023 18:23

Refactored isMessageWithSingleEmoticonOnly in TextMatchers to use reg…

f79db0b

…ex for single emoji check Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

updated license header

348de75

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

updated license header

895ad52

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in> updated license header Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Update dialog_create_conversation.xml

c4f3d88

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Update dialog_create_conversation.xml

2a2870f

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Update dialog_set_status.xml

1f9ad70

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

mahibi modified the milestones: 18.0.0, 18.1.0 Dec 1, 2023

Smarshal21 and others added 5 commits December 16, 2023 11:19

Merge remote-tracking branch 'origin/emoji2' into emoji2

b56d3eb

Fixed Keyboard Toggler

9eaa9bf

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Merge branch 'master' into emoji2

561fd03

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Fixed ktlintCheck and Codacy Static Code Analysis Errors

09968e4

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

Smarshal21 requested review from mahibi and rapterjet2004 December 16, 2023 15:21

AndyScherzinger requested review from sowjanyakch and removed request for AndyScherzinger December 18, 2023 13:52

mahibi modified the milestones: 18.1.0, 19.0.0 Mar 12, 2024

github-actions bot added the feedback-requested label Mar 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Google EmojiPicker #3439

Implemented Google EmojiPicker #3439

Smarshal21 commented Nov 8, 2023 •

edited by AndyScherzinger

Smarshal21 commented Nov 8, 2023

AndyScherzinger commented Nov 8, 2023

Smarshal21 commented Nov 8, 2023

rapterjet2004 commented Nov 9, 2023 •

edited

Smarshal21 commented Nov 9, 2023

rapterjet2004 commented Nov 9, 2023

Smarshal21 commented Nov 9, 2023

Smarshal21 commented Nov 9, 2023

mahibi commented Nov 10, 2023

rapterjet2004 left a comment

mahibi Nov 16, 2023

Smarshal21 Nov 18, 2023

mahibi Nov 28, 2023

Smarshal21 Nov 28, 2023

mahibi Nov 29, 2023

mahibi Nov 16, 2023

mahibi left a comment

github-actions bot commented Dec 16, 2023

github-actions bot commented Dec 16, 2023

Smarshal21 commented Dec 18, 2023

mahibi commented Jan 9, 2024 •

edited

Smarshal21 commented Feb 9, 2024

github-actions bot commented Mar 31, 2024

		@@ -1429,30 +1427,17 @@ class ChatActivity :
		private fun initSmileyKeyboardToggler() {

Implemented Google EmojiPicker #3439

Are you sure you want to change the base?

Implemented Google EmojiPicker #3439

Conversation

Smarshal21 commented Nov 8, 2023 • edited by AndyScherzinger

Description:

Changes Made:

Screenshots:

🏁 Checklist

Smarshal21 commented Nov 8, 2023

AndyScherzinger commented Nov 8, 2023

Smarshal21 commented Nov 8, 2023

rapterjet2004 commented Nov 9, 2023 • edited

Smarshal21 commented Nov 9, 2023

rapterjet2004 commented Nov 9, 2023

Smarshal21 commented Nov 9, 2023

Smarshal21 commented Nov 9, 2023

mahibi commented Nov 10, 2023

rapterjet2004 left a comment

Choose a reason for hiding this comment

mahibi Nov 16, 2023

Choose a reason for hiding this comment

Smarshal21 Nov 18, 2023

Choose a reason for hiding this comment

mahibi Nov 28, 2023

Choose a reason for hiding this comment

Smarshal21 Nov 28, 2023

Choose a reason for hiding this comment

mahibi Nov 29, 2023

Choose a reason for hiding this comment

mahibi Nov 16, 2023

Choose a reason for hiding this comment

mahibi left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 16, 2023

Codacy

Lint

SpotBugs

Lint increased!

github-actions bot commented Dec 16, 2023

Smarshal21 commented Dec 18, 2023

mahibi commented Jan 9, 2024 • edited

Smarshal21 commented Feb 9, 2024

github-actions bot commented Mar 31, 2024

Smarshal21 commented Nov 8, 2023 •

edited by AndyScherzinger

rapterjet2004 commented Nov 9, 2023 •

edited

mahibi commented Jan 9, 2024 •

edited