Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to Bubble Conversations #3399

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ability to Bubble Conversations #3399

wants to merge 1 commit into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 20, 2023 •
edited

bubbles-demo-1.webm

馃毀 TODO

  • Bubble Works
  • Enabled when conversation is marked is important
  • Use Conversation Avatar for bubble icon -_- no idea why this isn't working
  • Multiple bubbles for multiple conversations
  • Embedded view doesn't work
  • Error with multiple marked important conversations

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Oct 20, 2023
@AndyScherzinger AndyScherzinger added the enhancement New feature or request label Nov 6, 2023
@rapterjet2004
Bubbles
f522beb 
- Only enabled on Conversations deemed important
- Enabled ChatActivity to be resizable and embedded in Android Manifest

Signed-off-by: Julius Linus <julius.linus@nextcloud.com>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3399-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004 rapterjet2004 mentioned this pull request Dec 11, 2023
Closed
7 tasks
@rapterjet2004 rapterjet2004 added the stale On hold label Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rapterjet2004 rapterjet2004

Labels
2. developing Work in progress enhancement New feature or request feature: 馃敂 notifications feedback-requested stale On hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to "bubble" conversations
2 participants
@rapterjet2004 @AndyScherzinger