-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exports issue related to nextcloud-event-bus #4819
Conversation
Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Tested with Edge, the page loads fine. |
The last IE version is Nextcloud 22 IIRC? |
I found this (still open) ticket on server: nextcloud/server#20855
|
we might not need to backport if we don't upgrade babel-env-preset in stable versions |
No, the ticket is IE11 will be deprecated but should be mostly functional until 22. Another fix idea would be to downgrade the problematic lib again and add it to the ignore list of dependabot |
okay, so will retest with IE 11 to see if, by any chance, the old problem magically disappeared (ex: through recent babel updates):
|
with IE11 it does NOT work, an error about the event bus appear: as we can see it did not get transpiled for IE 11 maybe the transpiling should be done in the repo itself ? also, it seems talk alpha 2 build is broken as well with IE 11 due to nextcloud-vue, raised here: #4820 |
revert PR is here #4821 |
right, so the problem is that semver is not transpiled: nextcloud-libraries/nextcloud-event-bus#145 |
This is a partial revert of #3961 so better not backport to versions that need to support IE11.
Fixes #4818