Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports issue related to nextcloud-event-bus #4819

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 21, 2020

  • check that it still runs in Edge

This is a partial revert of #3961 so better not backport to versions that need to support IE11.

Fixes #4818

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@PVince81
Copy link
Member Author

Tested with Edge, the page loads fine.

@nickvergessen
Copy link
Member

This is a partial revert of #3961 so better not backport to versions that need to support IE11.

The last IE version is Nextcloud 22 IIRC?

@PVince81
Copy link
Member Author

This is a partial revert of #3961 so better not backport to versions that need to support IE11.

The last IE version is Nextcloud 22 IIRC?

I found this (still open) ticket on server: nextcloud/server#20855
As far as I understand:

  • IE11 deprecated in NC 20, Edge still supported
  • Edge still supported in NC 21, IE 11 not any more (which fits with my statement in this PR)
  • Edge also dropped in NC 22

@PVince81
Copy link
Member Author

PVince81 commented Dec 21, 2020

we might not need to backport if we don't upgrade babel-env-preset in stable versions

@nickvergessen
Copy link
Member

No, the ticket is IE11 will be deprecated but should be mostly functional until 22.
Edge is Chrome based and updates automatically, so not a problem at all.
But a blank page in talk is not "deprecated".

Another fix idea would be to downgrade the problematic lib again and add it to the ignore list of dependabot

@PVince81
Copy link
Member Author

PVince81 commented Dec 21, 2020

okay, so will retest with IE 11 to see if, by any chance, the old problem magically disappeared (ex: through recent babel updates):

  • retest with IE 11

@PVince81 PVince81 marked this pull request as draft December 21, 2020 09:57
@PVince81
Copy link
Member Author

with IE11 it does NOT work, an error about the event bus appear:
ie11-with-talk-pr

as we can see it did not get transpiled for IE 11

maybe the transpiling should be done in the repo itself ?

also, it seems talk alpha 2 build is broken as well with IE 11 due to nextcloud-vue, raised here: #4820

@PVince81
Copy link
Member Author

revert PR is here #4821

@PVince81 PVince81 closed this Dec 21, 2020
@ChristophWurst ChristophWurst deleted the bugfix/4818/fix-exports-issue branch December 21, 2020 12:37
@PVince81
Copy link
Member Author

right, so the problem is that semver is not transpiled: nextcloud-libraries/nextcloud-event-bus#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exports is not defined on master
3 participants