Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare vue3 branch #12352

Merged
merged 26 commits into from
May 15, 2024
Merged

Prepare vue3 branch #12352

merged 26 commits into from
May 15, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 14, 2024 •
edited

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🚧 Tasks

  • Remove unneeded in Vue 3 deps and migrate their usages (vue-frag, portal, compiler)
  • Remove dependencies that are not ready for Vue 3 yet (@nextcloud/dialogs, @nextcloud/uploads, nextcloud-vue-collections)
  • Comment out usages of uninstalled dependencies
  • Temporarily replace @nextcloud/dialogs toasts with OCP.Toast
  • Upgrade dependencies to Vue 3 (vue-frag, portal, compiler)
  • Migrate Vuex
  • Migrate VueRouter
  • Migrate Vue apps initialization
  • Remove this.$set / Vue.set and delete
  • Fix migration issue with :key and v-for on <template>

🏁 Checklist

IT DOESN'T WORK 😀

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme force-pushed the chore/vue-3-migration branch 2 times, most recently from d114f80 to 1bbe444 Compare May 15, 2024 11:54
@ShGKme ShGKme self-assigned this May 15, 2024
ShGKme added 20 commits May 15, 2024 14:39
@ShGKme
chore(vue3): migrate from vue-frag
7702403 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate from vue-simple-portal
34ddb8d 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(deps): remove unneeded in Vue 3 dependencies
aaebd46 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(deps): temporary remove @nextcloud/upload
088255c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): temporary disable @nextcloud/upload
6ea69f4 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(deps): temporary remove @nextcloud/dialogs in Vue 3
b9e292f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - remove styles import
7422640 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - remove imports
89bb893 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace showError
64214e2 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace showSuccess
e2eb1ca 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace showWarning
273b396 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace showInfo
2f69a50 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace showMessage
b6034b1 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - replace TOAST_*_TIMEOUT
5cc6058 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - remove FilePickerVue
bb4464b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): @nextcloud/dialogs - remove in tests
bf7d404 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(deps): temporary remove nextcloud-vue-collections
95a0978 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): temporary disable nextcloud-vue-collections
77e7b0c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(deps): upgrade deps to Vue 3 versions
7903128 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate to Vue Router 4
43aa0b4 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the chore/vue-3-migration branch 2 times, most recently from 8becd8c to 69a96b7 Compare May 15, 2024 12:41
@ShGKme ShGKme marked this pull request as ready for review May 15, 2024 12:51
@ShGKme
chore(vue3): migrate to Vuex 4
a06d707 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate to @vue-leaflet/vue-leaflet
b9edf15 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate vue init
f747594 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): remove $set/$delete
9583e31 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate :key on <template v-for>
c8e1ad4 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): migrate tsconfig to Vue 3
654b77b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme merged commit b3a21c5 into vue3 May 15, 2024
39 of 41 checks passed
@ShGKme ShGKme deleted the chore/vue-3-migration branch May 15, 2024 13:29
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Awaiting requested review from Antreesy

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@ShGKme ShGKme

Labels
3. to review technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ShGKme