fix(federation): use a value from response header to count invites #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
technical debt
feature: frontend 🖌️
DorraJaouad
reviewed
May 13, 2024
Comment on lines
125
to
127
| if (this.invitationsLoadedCount !== this.federationStore.pendingSharesCount) { | ||
| this.federationStore.getShares() | ||
| } |
There was a problem hiding this comment.
Count can be the same but the item can be different
There was a problem hiding this comment.
After removing this, there is no trigger to get new shares when modal is open. Either restore this with a risk of missing fetch in +n addition and -n removal situation or maybe add an interval fetch.
There was a problem hiding this comment.
We will still get new ones from the invitation, if it arrives at the same momebt
There was a problem hiding this comment.
From what I see, no update trigger is there to update the shares list.
…ount pending invites Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/11944/federation-headers-invite
branch
from
8d4ef2b
to
1a18d00
Compare
Antreesy
force-pushed
the
fix/11944/federation-headers-invite
branch
from
1a18d00
to
439fd7e
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/11944/federation-headers-invite
branch
from
439fd7e
to
94a42cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
X-Nextcloud-Talk-Federation-Invitesheader with the pending invitations on roo… #11944x-nextcloud-talk-federation-invitesto update counter within 30-sec interval🖌️ UI Checklist
🚧 Tasks
🏁 Checklist