Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(Conversation): do not render NcDialog if was not called explicitly #12337

Merged
merged 1 commit into from
May 29, 2024
Merged

[stable28] fix(Conversation): do not render NcDialog if was not called explicitly #12337

merged 1 commit into from
May 29, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes, jsut less errors in the console

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy
fix(Conversation): do not render NcDialog if was not called explicitly
27f6162 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🧡 Next Patch (28) milestone May 13, 2024
@Antreesy Antreesy self-assigned this May 13, 2024
@Antreesy Antreesy changed the title fix(Conversation): do not render NcDialog if was not called explicitly [stable28] fix(Conversation): do not render NcDialog if was not called explicitly May 13, 2024
@Antreesy Antreesy merged commit 621e31b into stable28 May 29, 2024
44 checks passed
@Antreesy Antreesy deleted the fix/stable28/ease-template branch May 29, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🧡 Next Patch (28)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Antreesy @nickvergessen @DorraJaouad