Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when target has DND on #12283

Merged

Conversation

skalidindi53
Copy link
Contributor

@skalidindi53 skalidindi53 commented May 5, 2024

☑️ Resolves

🚧 Tasks

  • Throws a new error if target is on DND

Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
lib/Service/ParticipantService.php Outdated Show resolved Hide resolved
lib/Service/ParticipantService.php Outdated Show resolved Hide resolved
lib/Service/ParticipantService.php Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

Maybe you can also duplicate the test in

Scenario: Silent call with dedicated ping does trigger notifications
When user "participant1" creates room "room" (v4)
| roomType | 2 |
| roomName | room |
And user "participant1" adds user "participant2" to room "room" with 200 (v4)
Given user "participant1" joins room "room" with 200 (v4)
Given user "participant2" joins room "room" with 200 (v4)
Given user "participant1" loads attendees attendee ids in room "room" (v4)
Given user "participant1" joins call "room" with 200 (v4)
| silent | true |
Then user "participant2" has the following notifications
| app | object_type | object_id | subject |
Given user "participant1" pings user "participant2" to join call "room" with 200 (v4)
Then user "participant2" has the following notifications
| app | object_type | object_id | subject |
| spreed | call | room | A group call has started in room |

add a check for the the expected status code (and message) when the user status was set to dnd using
* @When /^user "([^"]*)" set status to "([^"]*)" with (\d+)(?: \((v1)\))?$/

@skalidindi53 skalidindi53 force-pushed the skalidindi53/11282/fix-DND-Status branch from 965f5d4 to 179ab48 Compare May 6, 2024 21:52
@skalidindi53 skalidindi53 force-pushed the skalidindi53/11282/fix-DND-Status branch from 179ab48 to 8bbd112 Compare May 7, 2024 21:43
@skalidindi53 skalidindi53 marked this pull request as ready for review May 8, 2024 16:41
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feedback-requested labels May 8, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 8, 2024
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
@skalidindi53 skalidindi53 force-pushed the skalidindi53/11282/fix-DND-Status branch from 8bbd112 to 377a2f9 Compare May 13, 2024 16:07
@skalidindi53
Copy link
Contributor Author

Maybe you can also duplicate the test in

Scenario: Silent call with dedicated ping does trigger notifications
When user "participant1" creates room "room" (v4)
| roomType | 2 |
| roomName | room |
And user "participant1" adds user "participant2" to room "room" with 200 (v4)
Given user "participant1" joins room "room" with 200 (v4)
Given user "participant2" joins room "room" with 200 (v4)
Given user "participant1" loads attendees attendee ids in room "room" (v4)
Given user "participant1" joins call "room" with 200 (v4)
| silent | true |
Then user "participant2" has the following notifications
| app | object_type | object_id | subject |
Given user "participant1" pings user "participant2" to join call "room" with 200 (v4)
Then user "participant2" has the following notifications
| app | object_type | object_id | subject |
| spreed | call | room | A group call has started in room |

add a check for the the expected status code (and message) when the user status was set to dnd using

* @When /^user "([^"]*)" set status to "([^"]*)" with (\d+)(?: \((v1)\))?$/

Added the test case as well

@nickvergessen
Copy link
Member

/backport to stable29

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 3a608dc into nextcloud:main May 16, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify about DND status when trying to resend call notification
2 participants