-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LeftSidebar): get rid of server styles for settings button #12261
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ac3bc06
to
23da8a2
Compare
</NcButton> | ||
</div> | ||
<div class="left-sidebar__settings-button-container"> | ||
<NcButton type="tertiary" wide @click="showSettings"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be handled in/via https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue or a new component, to avoid all the custom code/handling in X apps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be handled in/via https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue or a new component, to avoid all the custom code/handling in X apps?
I though about it but I'm not sure about it.
This cannot be handled via NcAppNavigationSettings
(at least without making it a 2-in-1 component), because NcAppNavigationSettings
is about "deprecated" collapsible settings, not a button.
This could be a new component, but its usage would probably have more variability than commons:
- In some apps,
AppNavigation
is fulfilled with navigation items and the settings button should look like a navigation item (Files, Photos) - In some apps it would be secondary (Mail)
- In some apps it would be tertiary (Talk)
The only common is that it is a wide NcButton
.
But we can discuss it with designers in @nextcloud/vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with current state, as it draws much less attention (and looks better 😋 ):
The current state - in main
or in this PR (tertiary)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some apps it would be secondary (Mail)
In some apps it would be tertiary (Talk)
This is exactly why I think it should be a common component.
I'm not sure the difference is intentional.
In fact I think that Talk, Calendar and Mail should look the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state - ... this PR (tertiary)
As discussed above 🙈, Talk and Mail use simple NcButton as a trigger for opening a dialog, and Calendar has special component with "accordion" feature (<button>
!!)
So I'd say, it would be better to summon design team here, to come to a conclusion on appearance for all three apps (but not the functionality), then apply resulting styles on Mail and Vue-lib for Calendar.
Another approach could be to add #trigger slot in NcAppSettingsDialog and keep styles consistent for both components on library level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The accordion should go asap, in favor of the settings dialog with proper explanations.
I like both the secondary y and tertiary versions
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
☑️ Resolves
@nextcloud/vue
secondary
- same as other similar apps - Mail, Calendartertiary
- close to previous design🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist